[Starlingx-discuss] Analysis of patch 88b7bc7 for StartlingX upstreaming

Peters, Matt Matt.Peters at windriver.com
Thu Nov 29 12:58:31 UTC 2018

Hi Chenjie,
Since this isn’t causing a runtime issue at the moment, I think this can be fixed as part of the upstreaming where it can be reviewed in Gerrit.  If you are looking for confirmation of the changes prior to that I would create a pull request so it can be reviewed/merged prior.


From: "Xu, Chenjie" <chenjie.xu at intel.com>
Date: Wednesday, November 28, 2018 at 9:22 PM
To: "Peters, Matt" <Matt.Peters at windriver.com>
Cc: "starlingx-discuss at lists.starlingx.io" <starlingx-discuss at lists.starlingx.io>
Subject: RE: [Starlingx-discuss] Analysis of patch 88b7bc7 for StartlingX upstreaming

Hi Matt,
Thanks for your comments! An RFE has been written to upstream patch 88b7bc7. Before I submit the code, I think we should fix this bug. I think we can change the parameter “host” to “agent” in the following lines:
Please let me know what you think of the proposal.

Best Regards,
Xu, Chenjie

From: Peters, Matt [mailto:Matt.Peters at windriver.com]
Sent: Thursday, November 29, 2018 1:43 AM
To: Xu, Chenjie <chenjie.xu at intel.com>
Cc: starlingx-discuss at lists.starlingx.io
Subject: Re: [Starlingx-discuss] Analysis of patch 88b7bc7 for StartlingX upstreaming

Hello Chenjie,
I agree, this is a bug.  I think the only reason it hasn’t been an issue is because the only user of the get_fdb_entries RPC is the BGP agent and it is not passing a host in the request (it is None), therefore it excludes the attempt to try and access the parameter as an agent based on the condition in _create_agent_fdb.

Here is the BGP caller:

From: "Xu, Chenjie" <chenjie.xu at intel.com<mailto:chenjie.xu at intel.com>>
Date: Wednesday, November 28, 2018 at 10:11 AM
To: "Peters, Matt" <Matt.Peters at windriver.com<mailto:Matt.Peters at windriver.com>>
Cc: "starlingx-discuss at lists.starlingx.io<mailto:starlingx-discuss at lists.starlingx.io>" <starlingx-discuss at lists.starlingx.io<mailto:starlingx-discuss at lists.starlingx.io>>
Subject: [Starlingx-discuss] Analysis of patch 88b7bc7 for StartlingX upstreaming

Hi Matt,
I think that there exists a bug in patch 88b7bc7. Function _get_fdb_entries will call function _create­_agent_fdb by following line:
The variable “host” will be used to call _create_agent_fdb. However function _create_agent_fdb expects variable “agent”:
I think this should be a bug. Could you please help review and comment?

Best Regards,
Xu, Chenjie
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.starlingx.io/pipermail/starlingx-discuss/attachments/20181129/76b98154/attachment-0001.html>

More information about the Starlingx-discuss mailing list