[Starlingx-discuss] Question about patch upstreaming for e5712fe
Qin, Kailun
kailun.qin at intel.com
Mon Oct 15 02:05:07 UTC 2018
Hi Allain and Matt,
Thanks for confirming. We've retested the scenario w/o the change e5712fe and cannot reproduce the issue.
I think it's OK to drop the original patch e5712fe.
BR,
Kailun
From: Legacy, Allain [mailto:Allain.Legacy at windriver.com]
Sent: Friday, October 12, 2018 9:11 PM
To: Qin, Kailun <kailun.qin at intel.com>; Peters, Matt <Matt.Peters at windriver.com>
Cc: starlingx-discuss at lists.starlingx.io
Subject: RE: Question about patch upstreaming for e5712fe
Yes, your analysis is correct. Our patch (e5712fe) can be dropped because the issue has now been addressed by upstream commit (e45add7b07e5c72c43047d18e10af1c4ae307b0f).
Regards,
Allain
Allain Legacy, Software Developer, Wind River
direct 613.270.2279 fax 613.492.7870 skype allain.legacy
350 Terry Fox Drive, Suite 200, Ottawa, Ontario, K2K 2W5
[WIND]<http://www.windriver.com/>
From: Qin, Kailun [mailto:kailun.qin at intel.com]
Sent: Friday, October 12, 2018 6:33 AM
To: Peters, Matt
Cc: starlingx-discuss at lists.starlingx.io<mailto:starlingx-discuss at lists.starlingx.io>
Subject: [Starlingx-discuss] Question about patch upstreaming for e5712fe
Hi Matt,
We're looking into the patch e5712fe, which indicates a possible inconsistency/mismatch of tag values between dnsmasq option files and dnsmasq command line.
>From the commit message: "This seems to be happening because of how dhcp_rpc.py::_group_by_network_id would behave if the list of subnets coming from the database was ordered different or contained different values." After checking, we found that the latest Neutron seems to already have subnets sorted: https://github.com/openstack/neutron/blob/master/neutron/api/rpc/handlers/dhcp_rpc.py#L150L154.
Would you please kindly help double check on this? Let me know if any question. Thank you!
BR,
Kailun
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.starlingx.io/pipermail/starlingx-discuss/attachments/20181015/8ce54762/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image001.png
Type: image/png
Size: 1807 bytes
Desc: image001.png
URL: <http://lists.starlingx.io/pipermail/starlingx-discuss/attachments/20181015/8ce54762/attachment.png>
More information about the Starlingx-discuss
mailing list