[Starlingx-discuss] bashate failing in stx-integ in some reviews?

[Penney, Don]

Hi folks,

I'm seeing a couple of reviews in stx-integ failing the tox linter job on a bashate error, while most others are successful.

Happy in this test:
2018-10-31 03:06:25.270134 | ubuntu-xenial | Running bashate on /home/zuul/src/git.openstack.org/openstack/stx-integ/base/setup/files/custom.sh
2018-10-31 03:06:25.270348 | ubuntu-xenial | Running bashate on /home/zuul/src/git.openstack.org/openstack/stx-integ/base/initscripts/centos/files/mountnfs.sh

But failing in this one:
2018-10-31 08:21:56.690432 | ubuntu-xenial | Running bashate on /home/zuul/src/git.openstack.org/openstack/stx-integ/base/setup/files/custom.sh
2018-10-31 08:21:56.690706 | ubuntu-xenial | /home/zuul/src/git.openstack.org/openstack/stx-integ/base/setup/files/custom.sh:1:1: E004 File did not end with a newline
2018-10-31 08:21:56.690799 | ubuntu-xenial | 1 bashate error(s) found

The custom.sh script is definitely missing the EOL character, but that has been the case since it was created two years ago.

So I guess we just fix the script and rebase any failing reviews? It seems very odd that bashate would not always be reporting this error. The tox.ini bashate invocation has not changed recently, either.

Cheers,
Don.


Don Penney, Developer, Wind River


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.starlingx.io/pipermail/starlingx-discuss/attachments/20181031/f889c634/attachment.html>