[Starlingx-discuss] bashate failing in stx-integ in some reviews?

[Penney, Don]

Al noticed the failure is only reported if it's in the last file processed by bashate:

Sure enough:

$ bashate -v ../stx-integ/base/setup/files/prompt.sh ../stx-integ/base/setup/files/custom.sh
Running bashate on ../stx-integ/base/setup/files/prompt.sh
Running bashate on ../stx-integ/base/setup/files/custom.sh
../stx-integ/base/setup/files/custom.sh:1:1: E004 File did not end with a newline
1 bashate error(s) found
$ bashate -v ../stx-integ/base/setup/files/custom.sh ../stx-integ/base/setup/files/prompt.sh
Running bashate on ../stx-integ/base/setup/files/custom.sh
Running bashate on ../stx-integ/base/setup/files/prompt.sh



-----Original Message-----
From: Penney, Don [mailto:Don.Penney at windriver.com] 
Sent: Wednesday, October 31, 2018 9:52 AM
To: Dean Troyer
Cc: starlingx-discuss at lists.starlingx.io
Subject: Re: [Starlingx-discuss] bashate failing in stx-integ in some reviews?

Failure case:
http://logs.openstack.org/84/614384/5/check/openstack-tox-linters/70d0ace/job-output.txt.gz

Success case:
http://logs.openstack.org/23/613823/7/check/openstack-tox-linters/03e4b93/job-output.txt.gz



-----Original Message-----
From: Dean Troyer [mailto:dtroyer at gmail.com] 
Sent: Wednesday, October 31, 2018 9:47 AM
To: Penney, Don
Cc: starlingx-discuss at lists.starlingx.io
Subject: Re: [Starlingx-discuss] bashate failing in stx-integ in some reviews?

On Wed, Oct 31, 2018 at 5:47 AM Penney, Don <Don.Penney at windriver.com> wrote:
> I’m seeing a couple of reviews in stx-integ failing the tox linter job on a bashate error, while most others are successful.
> Happy in this test:
> 2018-10-31 03:06:25.270134 | ubuntu-xenial | Running bashate on /home/zuul/src/git.openstack.org/openstack/stx-integ/base/setup/files/custom.sh
>
> But failing in this one:
> 2018-10-31 08:21:56.690432 | ubuntu-xenial | Running bashate on /home/zuul/src/git.openstack.org/openstack/stx-integ/base/setup/files/custom.sh
> 2018-10-31 08:21:56.690706 | ubuntu-xenial | /home/zuul/src/git.openstack.org/openstack/stx-integ/base/setup/files/custom.sh:1:1: E004 File did not end with a newline
>
> So I guess we just fix the script and rebase any failing reviews? It seems very odd that bashate would not always be reporting this error. The tox.ini bashate invocation has not changed recently, either.

Yeah, that is odd.  Can you send links tot he reviews those came from?
 I think it would be interesting to see what is different between the
job runs, ie cloud provider and such.  There _shouldn't_ be anything
that matters different...

dt

-- 

Dean Troyer
dtroyer at gmail.com
_______________________________________________
Starlingx-discuss mailing list
Starlingx-discuss at lists.starlingx.io
http://lists.starlingx.io/cgi-bin/mailman/listinfo/starlingx-discuss