[Starlingx-discuss] Service Parameter Bug 1818887

[Arce Moreno, Abraham]

Hi,

I need your advice how to interpret my findings related to this bug:

  https://bugs.launchpad.net/starlingx/+bug/1818887
  Failed to apply run-time manifest after the http port was modified

I will take this review as my initial learning source:
  https://review.opendev.org/#/c/634237
  Configurable Host HTTP/HTTPS Port Binding

The test steps are:

  1. system service-parameter-modify http config http_port=6666
  2. system service-parameter-apply http

The expected behavior:
  After modifying http service-parameter Horizon dashboard should be accessbile on http port 6666

[ Fail ]
The first time service-parameter-apply is executed, there is a process error:

/var/log/sysinv.log

2019-08-21 21:48:55.208 1727887 INFO sysinv.agent.manager ... _apply_runtime_manifest with hieradata_path = '/opt/platform/puppet/19.01/hieradata' 
2019-08-21 21:48:55.209 1727887 WARNING sysinv.puppet.common ... /opt/platform/puppet/19.01/hieradata 192.168.204.3 controller runtime
2019-08-21 21:49:06.543 1727887 ERROR sysinv.puppet.common [req-20042efd-3d18-4231-85a8-fb38bdcb3a56 admin admin]
                                                                                    Failed to execute runtime manifest for host 192.168.204.3
2019-08-21 21:49:06.543 1727887 TRACE sysinv.puppet.common Traceback (most recent call last):
2019-08-21 21:49:06.543 1727887 TRACE sysinv.puppet.common CalledProcessError: Command '['/usr/local/bin/puppet-manifest-apply.sh', 
                                                                                   '/opt/platform/puppet/19.01/hieradata', '192.168.204.3', 'controller', 'runtime', '/tmp/tmpothK1t.yaml']'
                                                                                   returned non-zero exit status 1

/var/log/puppet/latest/puppet.log

2019-08-21T21:49:04.805 ... Exec[Adding StarlingX helm repo: stx-platform](provider=posix): Executing 'helm repo add stx-platform http://127.0.0.1:8083/helm_charts/stx-platform'
2019-08-21T21:49:04.810 ... Executing with uid=sysadmin gid=sys_protected: 'helm repo add stx-platform http://127.0.0.1:8083/helm_charts/stx-platform'
2019-08-21T21:49:04.840 ... /Stage[main]/Platform::Helm::Repositories/Platform::Helm::Repository[stx-platform]/Exec[Adding StarlingX helm repo: stx-platform]/returns: Error: Looks like "http://127.0.0.1:8083/helm_charts/stx-platform" is not a valid chart repository or cannot be reached: Failed to fetch http://127.0.0.1:8083/helm_charts/stx-platform/index.yaml : 404 Not Found
2019-08-21T21:49:04.843 Error: 2019-08-21 21:49:04 +0000 helm repo add stx-platform http://127.0.0.1:8083/helm_charts/stx-platform returned 1 instead of one of [0]

2019-08-21T21:49:04.983 ... Platform::Helm::Repository[stx-platform]: Resource is being skipped, unscheduling all events
2019-08-21T21:49:04.985 ... Exec[Adding StarlingX helm repo: starlingx](provider=posix): Executing 'helm repo add starlingx http://127.0.0.1:8083/helm_charts/starlingx'
2019-08-21T21:49:04.987 ... Executing with uid=sysadmin gid=sys_protected: 'helm repo add starlingx http://127.0.0.1:8083/helm_charts/starlingx'
2019-08-21T21:49:04.990 ... /Stage[main]/Platform::Helm::Repositories/Platform::Helm::Repository[starlingx]/Exec[Adding StarlingX helm repo: starlingx]/returns: Error: Looks like "http://127.0.0.1:8083/helm_charts/starlingx" is not a valid chart repository or cannot be reached: Failed to fetch http://127.0.0.1:8083/helm_charts/starlingx/index.yaml : 404 Not Found
2019-08-21T21:49:04.992 Error: 2019-08-21 21:49:04 +0000 helm repo add starlingx http://127.0.0.1:8083/helm_charts/starlingx returned 1 instead of one of [0]

[ Success ]
A second time service-parameter-apply is executed, we might have no process error, clearing the fault alarm.

[ Questions ]

Are we missing something under puppet-manifests/src/modules/platform/manifests/helm.pp?
A restart of "systemctl restart lighttpd.service" so new port value can be properly configured before trying to access 
http://127.0.0.1:8083/helm_charts/starlingx/?

Thanks for your advice!

Best Regards
Abraham