[Starlingx-discuss] [Stx.distro.openstack] Call for review on OpenStack Train Upgrade Patches.

Wed Nov 13 05:28:33 UTC 2019

Hi Don,

See my inline comment.

Thanks!
Zhipeng

-----Original Message-----
From: Penney, Don <Don.Penney at windriver.com> 
Sent: 2019年11月13日 11:49
To: Liu, ZhipengS <zhipengs.liu at intel.com>; Hu, Yong <yong.hu at intel.com>; 'starlingx-discuss at lists.starlingx.io' <starlingx-discuss at lists.starlingx.io>; Alonso, Juan Carlos <juan.carlos.alonso at intel.com>; Lemus Contreras, Cristopher J <cristopher.j.lemus.contreras at intel.com>
Subject: RE: [Stx.distro.openstack] Call for review on OpenStack Train Upgrade Patches.

1. Given the misconfiguration in stable-wheels.cfg, your last patchset to https://review.opendev.org/688105 would fail to build the tarball. Perhaps you made an update after the last time you successfully built the wheels tarball and forgot to rebuild?

Zhipeng:  Yes, I updated this patch VERY later with my comment, as I saw some incompatible error though they do not impact pod start/stop and sanity test.

2. A failure to build images that is overcome with a manual tweak in your workspace is still a failure to build. Anyone without your workaround, like CENGN, would hit this failure. We cannot launch a CENGN image build until I work through all the build issues, which I'm working on - I've got most of the images building, but still have a couple of failures that I should soon have resolved.

Zhipeng: Yes, we thought it will be OK with a clean build without workaround. We found the root cause but not used a right
Method, we should have consult you earlier. Sorry for that!

-----Original Message-----
From: Liu, ZhipengS [mailto:zhipengs.liu at intel.com] 
Sent: Tuesday, November 12, 2019 10:18 PM
To: Penney, Don; Hu, Yong; 'starlingx-discuss at lists.starlingx.io'; Alonso, Juan Carlos; Lemus Contreras, Cristopher J
Subject: RE: [Stx.distro.openstack] Call for review on OpenStack Train Upgrade Patches.

Hi Don,

From your patch, we learnt that we just need to change the entry in stable-wheels.cfg instread of our workaround.
Change pypi to tar in the second section of this line.
pyrsistent-0.15.4-cp27-cp27mu-linux_x86_64.whl|tar|https://files.pythonhosted.org/packages/b9/66/b2638d96a2d128b168d0dba60fdc77b7800a9b4a5340cefcc5fc4eae6295/pyrsistent-0.15.4.tar.gz|pyrsistent-0.15.4

Thanks!
Zhipeng

-----Original Message-----
From: Liu, ZhipengS 
Sent: 2019年11月13日 10:09
To: Penney, Don <Don.Penney at windriver.com>; Hu, Yong <yong.hu at intel.com>; starlingx-discuss at lists.starlingx.io; Alonso, Juan Carlos <juan.carlos.alonso at intel.com>; Lemus Contreras, Cristopher J <cristopher.j.lemus.contreras at intel.com>
Subject: RE: [Stx.distro.openstack] Call for review on OpenStack Train Upgrade Patches.

Hi Don,

Yes, I built wheels, as you can see in my patch https://review.opendev.org/#/c/688105/
I have changed stable-wheels.cfg when I debug neutron pod.
When I was doing integration test with train, upstream was also doing integration test as I can see the upper-constraints.txt was changing day by day.

BTW, we met the same issue you had.
ERROR: Could not find a version that satisfies the requirement pyrsistent===0.15.4 (from -c /tmp/whee ls/upper-constraints.txt (line 566)) (from versions: none)
ERROR: No matching distribution found for pyrsistent===0.15.4 (from -c /tmp/wheels/upper-constraints.tx t (line 566))

We have a WR below as pip can only find tar , no .whl can be found for pyrsistent.
================================================================
/home/wrsroot/starlingx/workspace/localdisk/loadbuild/wrsroot/starlingx/std/build-images/loci/scripts/pip_install.sh

#!/bin/bash
set -ex
packages=$@
#pip install --no-cache-dir --only-binary :all: --no-compile -c /tmp/wheels/upper-constraints.txt --find-links /tmp/wheels/ ${PIP_ARGS}${packages} pip install --no-compile -c /tmp/wheels/upper-constraints.txt --find-links /tmp/wheels/ pyrsistent pip install --no-cache-dir --only-binary :all: --no-compile -c /tmp/wheels/upper-constraints.txt --find-links /tmp/wheels/ ${PIP_ARGS} ${packages} ======================================================================

Thanks!
Zhipeng

-----Original Message-----
From: Penney, Don <Don.Penney at windriver.com>
Sent: 2019年11月13日 5:54
To: Liu, ZhipengS <zhipengs.liu at intel.com>; Hu, Yong <yong.hu at intel.com>; starlingx-discuss at lists.starlingx.io; Alonso, Juan Carlos <juan.carlos.alonso at intel.com>; Lemus Contreras, Cristopher J <cristopher.j.lemus.contreras at intel.com>
Subject: RE: [Stx.distro.openstack] Call for review on OpenStack Train Upgrade Patches.

Did you build wheels and docker images as part of testing? In addition to the wheel tarball build failure I hit earlier this afternoon (see email: " wheel tarball build broken by train upgrade - review needed in stx/root"), I decided to try building stx-ironic (an arbitrary choice), and hit a failure:

ERROR: Could not find a version that satisfies the requirement pyrsistent===0.15.4 (from -c /tmp/wheels/upper-constraints.txt (line 566)) (from versions: none)
ERROR: No matching distribution found for pyrsistent===0.15.4 (from -c /tmp/wheels/upper-constraints.txt (line 566))

-----Original Message-----
From: Liu, ZhipengS [mailto:zhipengs.liu at intel.com]
Sent: Thursday, November 07, 2019 8:55 PM
To: Hu, Yong; starlingx-discuss at lists.starlingx.io; Alonso, Juan Carlos; Lemus Contreras, Cristopher J
Subject: Re: [Starlingx-discuss] [Stx.distro.openstack] Call for review on OpenStack Train Upgrade Patches.

Hi all,

So far I have not got new more comments. 
I'd like to push this 6 patches get merged soon since fully sanity test pass!

Could core reviewers final check them before adding review+2 for below 3 patches.
https://review.opendev.org/#/c/683886/   starlingx/openstack-armada-app
https://review.opendev.org/#/c/684166/   starlingx/openstack-armada-app
https://review.opendev.org/#/c/688105/   starlingx/root

Thanks!
Zhipeng
-----Original Message-----
From: Hu, Yong <yong.hu at intel.com>
Sent: 2019年11月5日 22:47
To: starlingx-discuss at lists.starlingx.io; Alonso, Juan Carlos <juan.carlos.alonso at intel.com>; Liu, ZhipengS <zhipengs.liu at intel.com>; Lemus Contreras, Cristopher J <cristopher.j.lemus.contreras at intel.com>
Subject: [Stx.distro.openstack] Call for review on OpenStack Train Upgrade Patches.

Hi Core reviewers in Stx.distro.openstack:

The EB with containerized Train OpenStack services has *passed* the sanity, based on test results from testing team. (Thanks to @JC and @Chirstopher).

So to unblock stx.3.0 MS-3, please review the following patches in time:

     https://review.opendev.org/#/c/683886/
     https://review.opendev.org/#/c/683910/
     https://review.opendev.org/#/c/684166/
     https://review.opendev.org/#/c/687441/
     https://review.opendev.org/#/c/687197/
     https://review.opendev.org/#/c/688105/

In addition, some background info related to this upgrade:

1). Originally there was a test failure in the sanity, but later Zhipeng found the cause was from an non-standard test (cirros) image which had 2
QCOW2 headers unexpectedly and failed during the conversion from QCOW2 to RAW format. Why wasn't this issue seen with OpenStack Stein? Because the QCOW2 to RAW conversion wasn't enabled in Nova of Stein, but it is now enabled by default in Train.  Recommendation: later for the testing, we advise to use this cirros image: 
https://download.cirros-cloud.net/0.4.0/cirros-0.4.0-x86_64-disk.img, or other QCOW2 image which we assure it is with correct header.

2). these patches have to be merged *in one batch* due to the inter-dependencies.

3). after these patches are merged, need *stx.build team* to generate new docker images for Openstack Train services and *upload them to Docker Hub*.
_______________________________________________
Starlingx-discuss mailing list
Starlingx-discuss at lists.starlingx.io
http://lists.starlingx.io/cgi-bin/mailman/listinfo/starlingx-discuss