[Starlingx-discuss] Need help with commit

[Saul Wold]

On 4/29/20 6:56 AM, Bailey, Henry Albert (Al) wrote:
> I uploaded a fix, by clamping pylint (same as I did for 2 other repos 
> that hit the same issue).
> https://bugs.launchpad.net/starlingx/+bug/1875705
> Your review will merge through a 'recheck' after this one merges.
> 
Are we sure we want to clamp the version, don't we want to file LP or 
stories against the pylint issues and fix them and then release the clamp?

Maybe we need a general pylint story?

I think that we should be keeping up with pylint as it can find real issues.

> If someone wants to keep pylint floating on its latest release (which 
> could cause another break the next time one is released), they could 
> update the 'is_ceph_healthy' method, and/or the 2 places it is called to 
> resolve the issue.
>


> Al
> ------------------------------------------------------------------------
> *From:* Saul Wold <sgw at linux.intel.com>
> *Sent:* Tuesday, April 28, 2020 12:07 PM
> *To:* starlingx-discuss at lists.starlingx.io 
> <starlingx-discuss at lists.starlingx.io>
> *Subject:* Re: [Starlingx-discuss] Need help with commit
> 
> 
> On 4/28/20 8:52 AM, Trica, Mihail-Laurentiu wrote:
>> Hello,
>> 
>> I have made a few commits and there is just one that is up for review: 
>> https://review.opendev.org/#/c/716554/. I have modified the commit
>> following commit review. Yang Liu has been the one that reviewed my 
>> commit and the commits of my fellow Intel colleagues. Yang gave it a 
>> Code Review +2 and a Workflow +1 and Zuul started its checks again. What 
>> I can see now is that Zuul gave it a -2 because one of its pylint check 
>> failed(logs are available HERE 
>> <https://zuul.opendev.org/t/openstack/build/d39f574ea3bb4b9089981af9c169b294>). 
> 
>> The only problem is that it had give it a +1 after I made my final 
>> changes. Basically the history for the last patchset is this one:
>> 
>> - I uploaded patchset 6, Zuul started its jobs, gave it +1
>> 
>> - Yang did the code review and gave it a Code Review +2 and a Workflow +1
>> 
>> - finally Zuul restarted its checks, but it had an error for the pylint 
>> job and it gave it a -2
>> 
> pylint was changed recently to a newer / stricter version that's why
> your getting new errors.
> 
>>  From the logs the error is not on any of the files that I modified in 
>> the commit, but on: 
>> “automated-pytest-suite/keywords/storage_helper.py:424:8: E0633: 
>> Attempting to unpack a non-sequence defined at line 52 
>> (unpacking-non-sequence)”. My code is not even using storage-helper. How 
>> can subsequent checks fail on code that has not been modified? Is there 
>> a way to re-trigger Zuul checks? In the meantime I have rebased the commit.
>>
> It's failing not because of the code you added, but because pylint is
> checking all the code and found an issue since it's running with
> stricter rules now.
> 
> you can add a "recheck" reply to your commit from review.opendev.org.
> 
> Hope that helps
> 
>      Sau!
> 
>> Toate cele bune/Kind regards/Mit freundlichen 
>> Grüßen/Cordialement/Cordiali saluti/с уважением/z poważaniem
>> 
>> よろしくお願いいたします
>> 
>> 此致
>> 
>> 敬礼
>> 
>> *Mihail-Laurenţiu Trică*, Software Engineer
>> 
>> 
>> _______________________________________________
>> Starlingx-discuss mailing list
>> Starlingx-discuss at lists.starlingx.io
>> http://lists.starlingx.io/cgi-bin/mailman/listinfo/starlingx-discuss
>> 
> 
> _______________________________________________
> Starlingx-discuss mailing list
> Starlingx-discuss at lists.starlingx.io
> http://lists.starlingx.io/cgi-bin/mailman/listinfo/starlingx-discuss