[Starlingx-discuss] RVMC in meta/centos_pkg_dirs

[Penney, Don]

Oddly, it's logged as an "ERROR", but has a "return 0" like it's a warning. So easy enough to make it a fatal error. And there's at least one other warning in the same function that looks like it should be a fatal, right after this one.
https://opendev.org/starlingx/root/src/branch/master/build-tools/build-srpms-parallel#L437-L450



-----Original Message-----
From: Saul Wold [mailto:sgw at linux.intel.com] 
Sent: Wednesday, January 15, 2020 6:45 PM
To: starlingx-discuss at lists.starlingx.io
Subject: Re: [Starlingx-discuss] RVMC in meta/centos_pkg_dirs

Don,

Great, I will file a LP and deal with cleaning it up.  Is there any 
checks for these kind of errors in the build system?  Clearly this has 
been there for a bit and ignored.

Maybe a SB is needed to add somekind of checking if that's possible.

Sau!


On 1/15/20 3:39 PM, Penney, Don wrote:
> No, and it wouldn't need the build_srpm.data file, either. This is for a docker image, not on-host package.
> 
> -----Original Message-----
> From: Saul Wold [mailto:sgw at linux.intel.com]
> Sent: Wednesday, January 15, 2020 6:36 PM
> To: starlingx-discuss at lists.starlingx.io
> Subject: [Starlingx-discuss] RVMC in meta/centos_pkg_dirs
> 
> 
> Scott, Don:
> 
> I am the following error which indeed seems to be the case, does rvmc
> belong in the centos_pkg_dirs if it does not have an RPM specfile?
> 
> ERROR: build_dir (425): Neither srpm_path nor .spec file not found in
> '/localdisk/designer/swold/stx/cgcs-root/stx/metal/tools/rvmc/centos'
> 
> $ ls metal/tools/rvmc/centos
> build_srpm.data  docker  rvmc.stable_docker_image
> 
> I can file a launchpad as needed.
> 
> Sau!
> 
> _______________________________________________
> Starlingx-discuss mailing list
> Starlingx-discuss at lists.starlingx.io
> http://lists.starlingx.io/cgi-bin/mailman/listinfo/starlingx-discuss
> _______________________________________________
> Starlingx-discuss mailing list
> Starlingx-discuss at lists.starlingx.io
> http://lists.starlingx.io/cgi-bin/mailman/listinfo/starlingx-discuss
> 

_______________________________________________
Starlingx-discuss mailing list
Starlingx-discuss at lists.starlingx.io
http://lists.starlingx.io/cgi-bin/mailman/listinfo/starlingx-discuss