[Starlingx-discuss] Change in ...app-sriov-fec-operator[master]: sriov-fec-operator system app integration

Short, Charles Charles.Short at windriver.com
Thu Sep 1 14:57:05 UTC 2022


Hi,

Since we are discussing this now, I think we should have the discussion to move from testing with Python3.6 to Python3.9 since Centos 7 is going away.

Regards
chuck

From: Brito, Thiago <Thiago.Brito at windriver.com>
Sent: Thursday, September 1, 2022 10:44 AM
To: Shivashankara Belur, Nidhi <nidhi.shivashankara.belur at intel.com>; Khalil, Ghada <Ghada.Khalil at windriver.com>; Burla, Balendu <balendu.burla at intel.com>
Cc: starlingx-discuss at lists.starlingx.io
Subject: Re: [Starlingx-discuss] Change in ...app-sriov-fec-operator[master]: sriov-fec-operator system app integration

To use python3.9, you'd have to change the nodeset on .zuul.yaml to debian-bullseye (copy from python3.9 and you should be good)[1]. On tox.ini, you need to use the same upper-constraints as you do for python3.9 (the one that comes from starlingx/root)[2].

You can find a good example on [3] where I defaulted all envs for python3.9 and used 3.6 only on venvs that doesn't have support for python3.9. Make sure you execute those tox tests locally before you try to make zuul try them (just because it's easier to spot any requirement inconsistency running locally). You can test using the same command zuul uses (tox -c python-k8sapp-sriov-fec-operator/k8sapp_sriov_fec_operator/tox.ini -e pylint).

[1]https://review.opendev.org/c/starlingx/app-sriov-fec-operator/+/845179/19/.zuul.yaml#19<https://urldefense.com/v3/__https:/review.opendev.org/c/starlingx/app-sriov-fec-operator/*/845179/19/.zuul.yaml*19__;KyM!!AjveYdw8EvQ!equq9gRwKVD3x-iPsXO51CfrRqJEQC8dGtaliAJsJa7xh6RYW3lE9f8nKoLIVDnEn3AMqEBn80AKmywhVCgfupP6DxggqYA$>
[2]https://review.opendev.org/c/starlingx/app-sriov-fec-operator/+/845179/19/python-k8sapp-sriov-fec-operator/k8sapp_sriov_fec_operator/tox.ini#27<https://urldefense.com/v3/__https:/review.opendev.org/c/starlingx/app-sriov-fec-operator/*/845179/19/python-k8sapp-sriov-fec-operator/k8sapp_sriov_fec_operator/tox.ini*27__;KyM!!AjveYdw8EvQ!equq9gRwKVD3x-iPsXO51CfrRqJEQC8dGtaliAJsJa7xh6RYW3lE9f8nKoLIVDnEn3AMqEBn80AKmywhVCgfupP6is6WGTs$>
[3]https://github.com/starlingx/openstack-armada-app/blob/master/python-k8sapp-openstack/k8sapp_openstack/tox.ini<https://urldefense.com/v3/__https:/github.com/starlingx/openstack-armada-app/blob/master/python-k8sapp-openstack/k8sapp_openstack/tox.ini__;!!AjveYdw8EvQ!equq9gRwKVD3x-iPsXO51CfrRqJEQC8dGtaliAJsJa7xh6RYW3lE9f8nKoLIVDnEn3AMqEBn80AKmywhVCgfupP6tez2ldg$>


Thiago
________________________________
From: Shivashankara Belur, Nidhi <nidhi.shivashankara.belur at intel.com>
Sent: Thursday, September 1, 2022 11:03 AM
To: Brito, Thiago <Thiago.Brito at windriver.com>; Khalil, Ghada <Ghada.Khalil at windriver.com>; Burla, Balendu <balendu.burla at intel.com>
Cc: starlingx-discuss at lists.starlingx.io <starlingx-discuss at lists.starlingx.io>
Subject: RE: Change in ...app-sriov-fec-operator[master]: sriov-fec-operator system app integration


[Please note: This e-mail is from an EXTERNAL e-mail address]

Thank you for the suggestion. I would like to try another build with including nodeset as ubuntu-bionic in .zuul.com<https://urldefense.com/v3/__http:/zuul.com__;!!AjveYdw8EvQ!dIbCDtEAD10q_JpE4NYrHmR9gYYOxeTpJ7IaXhNJuKJ3uzg58_2pasdFlyfID6rMdP5P4ZPyDbyPJ7Bo3HSYKo0HqTC-Fhc$>. Does that require python3.6 as well or can we change it back to python3?



In case the above still fails, what are all the files that needs to be modified and what are the changes that needs to be made in order to change everything to python3.9?

Are there any other applications that I can refer to which already have moved to python3.9 for pylint zuul job?



Nidhi

From: Brito, Thiago <Thiago.Brito at windriver.com>
Sent: Thursday, September 1, 2022 6:03 AM
To: Shivashankara Belur, Nidhi <nidhi.shivashankara.belur at intel.com>; Khalil, Ghada <ghada.khalil at windriver.com>; Burla, Balendu <balendu.burla at intel.com>
Cc: starlingx-discuss at lists.starlingx.io
Subject: Re: Change in ...app-sriov-fec-operator[master]: sriov-fec-operator system app integration



Log says "InterpreterNotFound". The node you zuul is running it into (ubuntu-focal) doesn't have python3.6. You can either change your nodeset to "ubuntu-bionic" on .zuul.yaml or, as I said before, change everything to python3.9 (running on debian-bullseye) and don't carry technical debt from start.



Thiago

________________________________

From: Shivashankara Belur, Nidhi <nidhi.shivashankara.belur at intel.com<mailto:nidhi.shivashankara.belur at intel.com>>
Sent: Wednesday, August 31, 2022 8:23 PM
To: Brito, Thiago <Thiago.Brito at windriver.com<mailto:Thiago.Brito at windriver.com>>; Khalil, Ghada <Ghada.Khalil at windriver.com<mailto:Ghada.Khalil at windriver.com>>; Burla, Balendu <balendu.burla at intel.com<mailto:balendu.burla at intel.com>>
Cc: starlingx-discuss at lists.starlingx.io<mailto:starlingx-discuss at lists.starlingx.io> <starlingx-discuss at lists.starlingx.io<mailto:starlingx-discuss at lists.starlingx.io>>
Subject: RE: Change in ...app-sriov-fec-operator[master]: sriov-fec-operator system app integration



[Please note: This e-mail is from an EXTERNAL e-mail address]

I updated the pylint env from "python3" to "python3.6", but it still failed.



GLOB sdist-make: /home/zuul/src/opendev.org/starlingx/app-sriov-fec-operator/python-k8sapp-sriov-fec-operator/k8sapp_sriov_fec_operator/setup.py<https://urldefense.com/v3/__http:/opendev.org/starlingx/app-sriov-fec-operator/python-k8sapp-sriov-fec-operator/k8sapp_sriov_fec_operator/setup.py__;!!AjveYdw8EvQ!Zli4SMLuBk9xMBWvBwk3QQXyLT7QTcb1xHhX9eg3bJqiLOPZkFK74boarZo6UwZrYkVKzp7HWOj2N23jt-zKU4QN58q5VOg$>
pylint create: /tmp/zuul_k8sapp_sriov_fec_operatortox/pylint
ERROR: InterpreterNotFound: python3.6
___________________________________ summary ____________________________________
ERROR:  pylint: InterpreterNotFound: python3.6





Link: Zuul Build (opendev.org)<https://urldefense.com/v3/__https:/zuul.opendev.org/t/openstack/build/dd696b12f92548da93da4fe3a6104ab4__;!!AjveYdw8EvQ!Zli4SMLuBk9xMBWvBwk3QQXyLT7QTcb1xHhX9eg3bJqiLOPZkFK74boarZo6UwZrYkVKzp7HWOj2N23jt-zKU4QNqWH4nb8$>



Can you please suggest what is the fix for this issue?



Thank you,

Nidhi

From: Brito, Thiago <Thiago.Brito at windriver.com<mailto:Thiago.Brito at windriver.com>>
Sent: Wednesday, August 31, 2022 8:07 AM
To: Khalil, Ghada <ghada.khalil at windriver.com<mailto:ghada.khalil at windriver.com>>; Shivashankara Belur, Nidhi <nidhi.shivashankara.belur at intel.com<mailto:nidhi.shivashankara.belur at intel.com>>; Burla, Balendu <balendu.burla at intel.com<mailto:balendu.burla at intel.com>>
Cc: starlingx-discuss at lists.starlingx.io<mailto:starlingx-discuss at lists.starlingx.io>
Subject: Re: Change in ...app-sriov-fec-operator[master]: sriov-fec-operator system app integration



Hi,



Expanding the logs I see that the error is related to an unavailable bdist_wininst command during the wheel creation to install on the tox venv. It seems like this was deprecated on python3.8 (which is the default on the node being used when you provide basepython=python3) and removed from setuptools at some point during that cycle; but you are using the upper-requirements from Openstack stein in your tox setup, so I think it is installing a weird setuptools version.



I recommend using basepython=python3.6 for the pylint env (if you can manage to use python3.9 and the debian upper-constraints, it's even better, but I think you'd have to tweak zuul.yml to change the nodeset as well).



[1]https://discuss.python.org/t/remove-bdist-wininst-command/6434<https://urldefense.com/v3/__https:/discuss.python.org/t/remove-bdist-wininst-command/6434__;!!AjveYdw8EvQ!Zli4SMLuBk9xMBWvBwk3QQXyLT7QTcb1xHhX9eg3bJqiLOPZkFK74boarZo6UwZrYkVKzp7HWOj2N23jt-zKU4QNZzDIbzM$>

[Image removed by sender.]<https://urldefense.com/v3/__https:/discuss.python.org/t/remove-bdist-wininst-command/6434__;!!AjveYdw8EvQ!Zli4SMLuBk9xMBWvBwk3QQXyLT7QTcb1xHhX9eg3bJqiLOPZkFK74boarZo6UwZrYkVKzp7HWOj2N23jt-zKU4QNZzDIbzM$>

Remove bdist_wininst command - Discussions on Python.org<https://urldefense.com/v3/__https:/discuss.python.org/t/remove-bdist-wininst-command/6434__;!!AjveYdw8EvQ!Zli4SMLuBk9xMBWvBwk3QQXyLT7QTcb1xHhX9eg3bJqiLOPZkFK74boarZo6UwZrYkVKzp7HWOj2N23jt-zKU4QNZzDIbzM$>

and that someone also steps up to actively maintain this and work on existing issues. FWIW, bdist_wininst is currently broken on 3.8+, and a PR has languished for over 3 months - but people can work around that by applying the patch to the python version that builds the distribution.

discuss.python.org<https://urldefense.com/v3/__http:/discuss.python.org__;!!AjveYdw8EvQ!Zli4SMLuBk9xMBWvBwk3QQXyLT7QTcb1xHhX9eg3bJqiLOPZkFK74boarZo6UwZrYkVKzp7HWOj2N23jt-zKU4QNEojdpo4$>





Thiago

________________________________

From: Khalil, Ghada <Ghada.Khalil at windriver.com<mailto:Ghada.Khalil at windriver.com>>
Sent: Wednesday, August 31, 2022 11:33 AM
To: Shivashankara Belur, Nidhi <nidhi.shivashankara.belur at intel.com<mailto:nidhi.shivashankara.belur at intel.com>>; Burla, Balendu <balendu.burla at intel.com<mailto:balendu.burla at intel.com>>
Cc: starlingx-discuss at lists.starlingx.io<mailto:starlingx-discuss at lists.starlingx.io> <starlingx-discuss at lists.starlingx.io<mailto:starlingx-discuss at lists.starlingx.io>>
Subject: Re: [Starlingx-discuss] Change in ...app-sriov-fec-operator[master]: sriov-fec-operator system app integration



Adding the stx-discuss mailing list for wider visibility in case someone is able to comment/help with. It appears that a "recheck" this morning still failed.



Thanks,

Ghada



PS: It's recommended to always include the mailing list on reported issues.



From: Shivashankara Belur, Nidhi <nidhi.shivashankara.belur at intel.com<mailto:nidhi.shivashankara.belur at intel.com>>
Sent: Tuesday, August 30, 2022 9:04 PM
To: Burla, Balendu <balendu.burla at intel.com<mailto:balendu.burla at intel.com>>; Shivashankara Belur, Nidhi <nidhi.shivashankara.belur at intel.com<mailto:nidhi.shivashankara.belur at intel.com>>; Khalil, Ghada <Ghada.Khalil at windriver.com<mailto:Ghada.Khalil at windriver.com>>; Somerville, Jim <Jim.Somerville at windriver.com<mailto:Jim.Somerville at windriver.com>>; Panech, Davlet <Davlet.Panech at windriver.com<mailto:Davlet.Panech at windriver.com>>; Little, Scott <Scott.Little at windriver.com<mailto:Scott.Little at windriver.com>>; Kantek, Andre Fernando Zanella <AndreFernandoZanella.Kantek at windriver.com<mailto:AndreFernandoZanella.Kantek at windriver.com>>; Koerich, Douglas Henrique <DouglasHenrique.Koerich at windriver.com<mailto:DouglasHenrique.Koerich at windriver.com>>; Ho, Teresa <Teresa.Ho at windriver.com<mailto:Teresa.Ho at windriver.com>>
Subject: RE: Change in ...app-sriov-fec-operator[master]: sriov-fec-operator system app integration



[Please note: This e-mail is from an EXTERNAL e-mail address]

Hi all,



pylint test is complaining about something in the k8sapp folder in the latest patchset 14. I have not uploaded any changes to this folder, infact the same job had passed yesterday in my last patchset 13. Can someone here please suggest where to look to resolve this issue? I didn't quite understand what the issue is.



Zuul Build (opendev.org)<https://urldefense.com/v3/__https:/zuul.opendev.org/t/openstack/build/a3568778b0ba40248feabf583b090dcf__;!!AjveYdw8EvQ!fGA8V8qgmEsUXdDR7buZCMAj1BgK8gjhLQFBYcA939Q0BZP6iX82r7G5LKmUi3HPfnTyyXaXQd4mBQjScMUmVgk86S9FByc$>



Regards,

Nidhi



From: Zuul (Code Review) <review at openstack.org<mailto:review at openstack.org>>
Sent: Tuesday, August 30, 2022 5:13 PM
To: Shivashankara Belur, Nidhi <nidhi.shivashankara.belur at intel.com<mailto:nidhi.shivashankara.belur at intel.com>>
Cc: Douglas Henrique Koerich <douglashenrique.koerich at windriver.com<mailto:douglashenrique.koerich at windriver.com>>; Somerville, Jim <jim.somerville at windriver.com<mailto:jim.somerville at windriver.com>>; Andre Kantek <AndreFernandoZanella.Kantek at windriver.com<mailto:AndreFernandoZanella.Kantek at windriver.com>>; Davlet Panech <davlet.panech at windriver.com<mailto:davlet.panech at windriver.com>>; Ho, Teresa <teresa.ho at windriver.com<mailto:teresa.ho at windriver.com>>; Khalil, Ghada <ghada.khalil at windriver.com<mailto:ghada.khalil at windriver.com>>; Scott Little <scott.little at windriver.com<mailto:scott.little at windriver.com>>; Burla, Balendu <balendu.burla at intel.com<mailto:balendu.burla at intel.com>>
Subject: Change in ...app-sriov-fec-operator[master]: sriov-fec-operator system app integration



Attention is currently required from: Jim Somerville, Ghada Khalil, Scott Little, Douglas Henrique Koerich, Nidhi Shivashankara Belur, Andre Kantek, Davlet Panech, Teresa Ho.

Build failed (check pipeline). For information on how to proceed, see
https://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing<https://urldefense.com/v3/__https:/docs.opendev.org/opendev/infra-manual/latest/developers.html*automated-testing__;Iw!!AjveYdw8EvQ!fGA8V8qgmEsUXdDR7buZCMAj1BgK8gjhLQFBYcA939Q0BZP6iX82r7G5LKmUi3HPfnTyyXaXQd4mBQjScMUmVgk8kGzSDSI$>

https://zuul.opendev.org/t/openstack/buildset/10fd7a2bb881467ca0a24a8464e0822f<https://urldefense.com/v3/__https:/zuul.opendev.org/t/openstack/buildset/10fd7a2bb881467ca0a24a8464e0822f__;!!AjveYdw8EvQ!fGA8V8qgmEsUXdDR7buZCMAj1BgK8gjhLQFBYcA939Q0BZP6iX82r7G5LKmUi3HPfnTyyXaXQd4mBQjScMUmVgk84K_6o-U$>

  *   openstack-tox-linters https://zuul.opendev.org/t/openstack/build/6b044bbf6fef4b17b011820fa393bdd4<https://urldefense.com/v3/__https:/zuul.opendev.org/t/openstack/build/6b044bbf6fef4b17b011820fa393bdd4__;!!AjveYdw8EvQ!fGA8V8qgmEsUXdDR7buZCMAj1BgK8gjhLQFBYcA939Q0BZP6iX82r7G5LKmUi3HPfnTyyXaXQd4mBQjScMUmVgk8L_trj_E$> : SUCCESS in 3m 06s
  *   k8sapp-sriov-fec-operator-tox-py39 https://zuul.opendev.org/t/openstack/build/79e763ffc9be4d76b000abdd40a9a604<https://urldefense.com/v3/__https:/zuul.opendev.org/t/openstack/build/79e763ffc9be4d76b000abdd40a9a604__;!!AjveYdw8EvQ!fGA8V8qgmEsUXdDR7buZCMAj1BgK8gjhLQFBYcA939Q0BZP6iX82r7G5LKmUi3HPfnTyyXaXQd4mBQjScMUmVgk87CH_Z-0$> : SUCCESS in 6m 26s
  *   k8sapp-sriov-fec-operator-tox-pylint https://zuul.opendev.org/t/openstack/build/a3568778b0ba40248feabf583b090dcf<https://urldefense.com/v3/__https:/zuul.opendev.org/t/openstack/build/a3568778b0ba40248feabf583b090dcf__;!!AjveYdw8EvQ!fGA8V8qgmEsUXdDR7buZCMAj1BgK8gjhLQFBYcA939Q0BZP6iX82r7G5LKmUi3HPfnTyyXaXQd4mBQjScMUmVgk86S9FByc$> : FAILURE in 4m 22s
  *

Patch set 14:Verified -1

View Change<https://urldefense.com/v3/__https:/review.opendev.org/c/starlingx/app-sriov-fec-operator/*/845179__;Kw!!AjveYdw8EvQ!fGA8V8qgmEsUXdDR7buZCMAj1BgK8gjhLQFBYcA939Q0BZP6iX82r7G5LKmUi3HPfnTyyXaXQd4mBQjScMUmVgk8kVtnqwI$>

To view, visit change 845179<https://urldefense.com/v3/__https:/review.opendev.org/c/starlingx/app-sriov-fec-operator/*/845179__;Kw!!AjveYdw8EvQ!fGA8V8qgmEsUXdDR7buZCMAj1BgK8gjhLQFBYcA939Q0BZP6iX82r7G5LKmUi3HPfnTyyXaXQd4mBQjScMUmVgk8kVtnqwI$>. To unsubscribe, or for help writing mail filters, visit settings<https://urldefense.com/v3/__https:/review.opendev.org/settings__;!!AjveYdw8EvQ!fGA8V8qgmEsUXdDR7buZCMAj1BgK8gjhLQFBYcA939Q0BZP6iX82r7G5LKmUi3HPfnTyyXaXQd4mBQjScMUmVgk8XA68eBk$>.

Gerrit-Project: starlingx/app-sriov-fec-operator

Gerrit-Branch: master

Gerrit-Change-Id: I1eee9e48a10e86be32e59bb83852c7bc179f0b44

Gerrit-Change-Number: 845179

Gerrit-PatchSet: 14

Gerrit-Owner: Nidhi Shivashankara Belur <nidhi.shivashankara.belur at intel.com<mailto:nidhi.shivashankara.belur at intel.com>>

Gerrit-Reviewer: Davlet Panech <davlet.panech at windriver.com<mailto:davlet.panech at windriver.com>>

Gerrit-Reviewer: Douglas Henrique Koerich <douglashenrique.koerich at windriver.com<mailto:douglashenrique.koerich at windriver.com>>

Gerrit-Reviewer: Ghada Khalil <ghada.khalil at windriver.com<mailto:ghada.khalil at windriver.com>>

Gerrit-Reviewer: Jim Somerville <jim.somerville at windriver.com<mailto:jim.somerville at windriver.com>>

Gerrit-Reviewer: Scott Little <scott.little at windriver.com<mailto:scott.little at windriver.com>>

Gerrit-Reviewer: Teresa Ho <teresa.ho at windriver.com<mailto:teresa.ho at windriver.com>>

Gerrit-Reviewer: Zuul

Gerrit-CC: Andre Kantek <AndreFernandoZanella.Kantek at windriver.com<mailto:AndreFernandoZanella.Kantek at windriver.com>>

Gerrit-CC: Balendu Mouli Burla <balendu.burla at intel.com<mailto:balendu.burla at intel.com>>

Gerrit-Attention: Jim Somerville <jim.somerville at windriver.com<mailto:jim.somerville at windriver.com>>

Gerrit-Attention: Ghada Khalil <ghada.khalil at windriver.com<mailto:ghada.khalil at windriver.com>>

Gerrit-Attention: Scott Little <scott.little at windriver.com<mailto:scott.little at windriver.com>>

Gerrit-Attention: Douglas Henrique Koerich <douglashenrique.koerich at windriver.com<mailto:douglashenrique.koerich at windriver.com>>

Gerrit-Attention: Nidhi Shivashankara Belur <nidhi.shivashankara.belur at intel.com<mailto:nidhi.shivashankara.belur at intel.com>>

Gerrit-Attention: Andre Kantek <AndreFernandoZanella.Kantek at windriver.com<mailto:AndreFernandoZanella.Kantek at windriver.com>>

Gerrit-Attention: Davlet Panech <davlet.panech at windriver.com<mailto:davlet.panech at windriver.com>>

Gerrit-Attention: Teresa Ho <teresa.ho at windriver.com<mailto:teresa.ho at windriver.com>>

Gerrit-Comment-Date: Wed, 31 Aug 2022 00:12:41 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.starlingx.io/pipermail/starlingx-discuss/attachments/20220901/b8b3f1cf/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ~WRD0000.jpg
Type: image/jpeg
Size: 823 bytes
Desc: ~WRD0000.jpg
URL: <https://lists.starlingx.io/pipermail/starlingx-discuss/attachments/20220901/b8b3f1cf/attachment-0001.jpg>


More information about the Starlingx-discuss mailing list