[Starlingx-discuss] Review of app-intel-ethernet-operator code

Tue Aug 8 18:49:55 UTC 2023

Likewise - I was able to take a pass at this review today.

Thanks!
-Joshua Reed

From: Pires Soares, Igor <Igor.PiresSoares at windriver.com>
Sent: Tuesday, August 8, 2023 12:25 PM
To: Walsh, Richard <richard.walsh at intel.com>; Lal, RafalX <rafalx.lal at intel.com>; Little, Scott <Scott.Little at windriver.com>; Khalil, Ghada <Ghada.Khalil at windriver.com>; Reed, Joshua <Joshua.Reed at windriver.com>
Cc: Webster, Steven <Steven.Webster at windriver.com>; Clarke, Kevin <kevin.clarke at intel.com>; starlingx-discuss at lists.starlingx.io; Kenny, Emma <emma.kenny at intel.com>; Juele, John Rey <john.rey.juele at intel.com>; Halim, Abdul <abdul.halim at intel.com>
Subject: Re: Review of app-intel-ethernet-operator code

It looks good on the Gerrit side now. I was able to proceed with the review there.

Regards,
Igor
________________________________
From: Walsh, Richard <richard.walsh at intel.com<mailto:richard.walsh at intel.com>>
Sent: Tuesday, August 8, 2023 7:09 AM
To: Lal, RafalX <rafalx.lal at intel.com<mailto:rafalx.lal at intel.com>>; Pires Soares, Igor <Igor.PiresSoares at windriver.com<mailto:Igor.PiresSoares at windriver.com>>; Little, Scott <Scott.Little at windriver.com<mailto:Scott.Little at windriver.com>>; Khalil, Ghada <Ghada.Khalil at windriver.com<mailto:Ghada.Khalil at windriver.com>>; Reed, Joshua <Joshua.Reed at windriver.com<mailto:Joshua.Reed at windriver.com>>
Cc: Webster, Steven <Steven.Webster at windriver.com<mailto:Steven.Webster at windriver.com>>; Clarke, Kevin <kevin.clarke at intel.com<mailto:kevin.clarke at intel.com>>; starlingx-discuss at lists.starlingx.io<mailto:starlingx-discuss at lists.starlingx.io> <starlingx-discuss at lists.starlingx.io<mailto:starlingx-discuss at lists.starlingx.io>>; Kenny, Emma <emma.kenny at intel.com<mailto:emma.kenny at intel.com>>; Juele, John Rey <john.rey.juele at intel.com<mailto:john.rey.juele at intel.com>>; Halim, Abdul <abdul.halim at intel.com<mailto:abdul.halim at intel.com>>
Subject: RE: Review of app-intel-ethernet-operator code

CAUTION: This email comes from a non Wind River email account!
Do not click links or open attachments unless you recognize the sender and know the content is safe.

@Pires Soares, Igor<mailto:Igor.PiresSoares at windriver.com> @Reed, Joshua<mailto:Joshua.Reed at windriver.com> - is there anything we need to/can help do from the Intel side here ?

I see this (with the turn-based set to Joshua I think)

[cid:image001.png at 01D9C9F6.D29FB500]

From: Lal, RafalX <rafalx.lal at intel.com<mailto:rafalx.lal at intel.com>>
Sent: Monday, August 7, 2023 7:01 PM
To: Pires Soares, Igor <Igor.PiresSoares at windriver.com<mailto:Igor.PiresSoares at windriver.com>>; Little, Scott <Scott.Little at windriver.com<mailto:Scott.Little at windriver.com>>; Khalil, Ghada <ghada.khalil at windriver.com<mailto:ghada.khalil at windriver.com>>; Reed, Joshua <Joshua.Reed at windriver.com<mailto:Joshua.Reed at windriver.com>>
Cc: Webster, Steven <steven.webster at windriver.com<mailto:steven.webster at windriver.com>>; Walsh, Richard <richard.walsh at intel.com<mailto:richard.walsh at intel.com>>; Clarke, Kevin <kevin.clarke at intel.com<mailto:kevin.clarke at intel.com>>; starlingx-discuss at lists.starlingx.io<mailto:starlingx-discuss at lists.starlingx.io>
Subject: RE: Review of app-intel-ethernet-operator code

It looks empty to me also.

Regards,

Rafal

From: Pires Soares, Igor <Igor.PiresSoares at windriver.com<mailto:Igor.PiresSoares at windriver.com>>
Sent: 04 August 2023 17:28
To: Little, Scott <Scott.Little at windriver.com<mailto:Scott.Little at windriver.com>>; Khalil, Ghada <ghada.khalil at windriver.com<mailto:ghada.khalil at windriver.com>>; Lal, RafalX <rafalx.lal at intel.com<mailto:rafalx.lal at intel.com>>; Reed, Joshua <Joshua.Reed at windriver.com<mailto:Joshua.Reed at windriver.com>>
Cc: Webster, Steven <steven.webster at windriver.com<mailto:steven.webster at windriver.com>>; Walsh, Richard <richard.walsh at intel.com<mailto:richard.walsh at intel.com>>; Clarke, Kevin <kevin.clarke at intel.com<mailto:kevin.clarke at intel.com>>; starlingx-discuss at lists.starlingx.io<mailto:starlingx-discuss at lists.starlingx.io>
Subject: Re: Review of app-intel-ethernet-operator code

It seems that I cannot +2 on the intel-ethernet-operator repo. The core group looks empty to me: https://review.opendev.org/admin/groups/b654c6ae66bdface82b16ac7e4f322f311dcc71e,members<https://urldefense.com/v3/__https:/review.opendev.org/admin/groups/b654c6ae66bdface82b16ac7e4f322f311dcc71e,members__;!!AjveYdw8EvQ!daIj2JOoRnSnu-1e8vuWlcgcYplUVwhkEWJJxc_LcjmjFMdzEyV2VfyH0qLy42yxuwG_9JbiUlXvygLgxXDPZdFP1AEd5A$>

Regards,

Igor

________________________________

From: Pires Soares, Igor <Igor.PiresSoares at windriver.com<mailto:Igor.PiresSoares at windriver.com>>
Sent: Friday, August 4, 2023 10:53 AM
To: Little, Scott <Scott.Little at windriver.com<mailto:Scott.Little at windriver.com>>; Khalil, Ghada <Ghada.Khalil at windriver.com<mailto:Ghada.Khalil at windriver.com>>; Lal, RafalX <rafalx.lal at intel.com<mailto:rafalx.lal at intel.com>>; Reed, Joshua <Joshua.Reed at windriver.com<mailto:Joshua.Reed at windriver.com>>
Cc: Webster, Steven <Steven.Webster at windriver.com<mailto:Steven.Webster at windriver.com>>; Walsh, Richard <richard.walsh at intel.com<mailto:richard.walsh at intel.com>>; Clarke, Kevin <kevin.clarke at intel.com<mailto:kevin.clarke at intel.com>>; starlingx-discuss at lists.starlingx.io<mailto:starlingx-discuss at lists.starlingx.io> <starlingx-discuss at lists.starlingx.io<mailto:starlingx-discuss at lists.starlingx.io>>
Subject: Re: [Starlingx-discuss] Review of app-intel-ethernet-operator code

Thanks, Ghada and Scott. I'll be reviewing it shortly. RafalX, in the meantime, feel free to get in touch in case you have any questions about the application framework standards.

Best regards,

Igor

________________________________

From: Little, Scott <Scott.Little at windriver.com<mailto:Scott.Little at windriver.com>>
Sent: Thursday, August 3, 2023 3:19 PM
To: Khalil, Ghada <Ghada.Khalil at windriver.com<mailto:Ghada.Khalil at windriver.com>>; Lal, RafalX <rafalx.lal at intel.com<mailto:rafalx.lal at intel.com>>; Pires Soares, Igor <Igor.PiresSoares at windriver.com<mailto:Igor.PiresSoares at windriver.com>>; Reed, Joshua <Joshua.Reed at windriver.com<mailto:Joshua.Reed at windriver.com>>
Cc: Webster, Steven <Steven.Webster at windriver.com<mailto:Steven.Webster at windriver.com>>; Walsh, Richard <richard.walsh at intel.com<mailto:richard.walsh at intel.com>>; Clarke, Kevin <kevin.clarke at intel.com<mailto:kevin.clarke at intel.com>>; starlingx-discuss at lists.starlingx.io<mailto:starlingx-discuss at lists.starlingx.io> <starlingx-discuss at lists.starlingx.io<mailto:starlingx-discuss at lists.starlingx.io>>
Subject: Re: Review of app-intel-ethernet-operator code

I've added the core reviewers per your request.

Scott

On 2023-08-03 12:41, Khalil, Ghada wrote:

To clarify, we need at @Little, Scott<mailto:Scott.Little at windriver.com> to add Steve, Johusa, and Igor as core reviews on the new repo: https://review.opendev.org/q/project:starlingx%252Fapp-intel-ethernet-operator<https://urldefense.com/v3/__https:/review.opendev.org/q/project:starlingx*252Fapp-intel-ethernet-operator__;JQ!!AjveYdw8EvQ!eVcCLq0F7JqXAlL2_Huaoy1GllQDsg-MdPVidsZxlF97aLbtZi4e7oEZNex6524o-3oZ-_lkrnSR4Zp65z040WO3w3YMKL3vz5mraw$>

Regards,

Ghada

From: Lal, RafalX <rafalx.lal at intel.com><mailto:rafalx.lal at intel.com>
Sent: Thursday, August 3, 2023 11:18 AM
To: Little, Scott <Scott.Little at windriver.com><mailto:Scott.Little at windriver.com>; Pires Soares, Igor <Igor.PiresSoares at windriver.com><mailto:Igor.PiresSoares at windriver.com>; Reed, Joshua <Joshua.Reed at windriver.com><mailto:Joshua.Reed at windriver.com>
Cc: Khalil, Ghada <Ghada.Khalil at windriver.com><mailto:Ghada.Khalil at windriver.com>; Webster, Steven <Steven.Webster at windriver.com><mailto:Steven.Webster at windriver.com>; Walsh, Richard <richard.walsh at intel.com><mailto:richard.walsh at intel.com>; Clarke, Kevin <kevin.clarke at intel.com><mailto:kevin.clarke at intel.com>
Subject: Review of app-intel-ethernet-operator code

CAUTION: This email comes from a non Wind River email account!
Do not click links or open attachments unless you recognize the sender and know the content is safe.

Hello,

I'm responsible for integration of Intel Ethernet Operator into StarlingX 9.0, and we are currently at the stage of pushing application code to opendev/starlingx repository. Review from Steven will be there, but core reviewers are needed to merge this change into the repository. I got suggestion from Ghada that you might be able to do that. This is the mentioned change<https://urldefense.com/v3/__https:/review.opendev.org/c/starlingx/app-intel-ethernet-operator/*/890199__;Kw!!AjveYdw8EvQ!fKzNzQece12g9rmPamZMa2uQhtIKbq1Tag4WeZPcKWTwOwg-3rIdQhpcDdrJP3X62iBvdgv8raiOFK1okCvItlOf$>. I would greatly appreciate if you would have a look at it in your free time.

Best Regards

Rafal

--------------------------------------------------------------
Intel Research and Development Ireland Limited
Registered in Ireland
Registered Office: Collinstown Industrial Park, Leixlip, County Kildare
Registered Number: 308263

This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.starlingx.io/pipermail/starlingx-discuss/attachments/20230808/dfe9de41/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image001.png
Type: image/png
Size: 97196 bytes
Desc: image001.png
URL: <https://lists.starlingx.io/pipermail/starlingx-discuss/attachments/20230808/dfe9de41/attachment-0001.png>