[Starlingx-discuss] Starlingx-discuss Digest, Vol 62, Issue 38

[Jeremy Stanley]

On 2023-07-20 03:08:05 +0000 (+0000), Liu, David wrote:
> I'm working on submit some code for review, and the zuul gate job
> failed, but I can't download the detailed logs, is there a problem
> with The CI server side?
> 
> My zuul job is here:
> https://zuul.opendev.org/t/openstack/build/760e0e486b024f9c9e5c5883af49299c/artifacts
[...]

I'm not sure what logs you think are missing, but the console log
there shows that the pyflakes static analysis tool you're running
encountered a fatal exception:

AttributeError: 'FlakesChecker' object has no attribute 'JOINEDSTR'

https://zuul.opendev.org/t/openstack/build/760e0e486b024f9c9e5c5883af49299c/log/job-output.txt#670

I'm able to reproduce this by checking out your change and running
`tox -e pep8 -c distributedcloud-client/tox.ini` under python3.7,
while running the same with a fresh checkout of the master branch
completes successfully, so there's definitely something about
https://review.opendev.org/888424 which is triggering the problem.

A quick web search on the exact error string turns up this mailing
list thread from 2019 about incompatibilities between the hacking
plugin and (then) newer flake8/pyflakes versions:

https://lists.openstack.org/pipermail/openstack-discuss/2019-November/011027.html

My best guess, without digging deeper, is that something in the code
being added in change 888424 is tickling the necessary code paths
through pyflakes to hit the incompatibility with hacking. Indeed,
editing distributedcloud-client/test-requirements.txt and bluntly
replacing the hacking entry with just flake8 gets it to succeed, but
of course this is only a reasonable solution if you don't care about
the additional rules that module was enforcing.
-- 
Jeremy Stanley
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: not available
URL: <https://lists.starlingx.io/pipermail/starlingx-discuss/attachments/20230720/8137522b/attachment.sig>