[Starlingx-discuss] Analysis of patch 4ae5a58 for StartlingX upstreaming
Hi Matt, We analyze the patch 4ae5a58 related to l2pop. An RFE has been written(You can find it in the attachment). Could you please help to review and comment? Thanks very much! Best Regards, Xu, Chenjie
Hi, I think the attached document would be a great candidate to be proposed as a spec to stx-specs. That way you can send out the link to the Gerrit review which works better with the mail archive as well as it is accessible from there too. Gerrit also helps with reviews but doesn’t force you to keep all the discussions there you can always reference the review link in mail threads. What do you think about moving the document there? Thanks, Ildikó
On 2018. Sep 17., at 9:17, Xu, Chenjie <chenjie.xu@intel.com> wrote:
Hi Matt, We analyze the patch 4ae5a58 related to l2pop. An RFE has been written(You can find it in the attachment). Could you please help to review and comment? Thanks very much!
Best Regards, Xu, Chenjie
<RFE_EXTEND_L2POP_FDB_INFORMATION.docx>_______________________________________________ Starlingx-discuss mailing list Starlingx-discuss@lists.starlingx.io http://lists.starlingx.io/cgi-bin/mailman/listinfo/starlingx-discuss
Hi Ildikó, This RFE is specific to neutron, therefore I think it makes sense to publish this to the neutron-specs for review rather than the stx-specs. I do agree that the mailing list is not the best way to exchange review comments and makes sense to ensure the docs are pushed to an appropriate spec repo as soon as possible. Regards, Matt On 2018-09-18, 3:46 AM, "Ildiko Vancsa" <ildiko.vancsa@gmail.com> wrote: Hi, I think the attached document would be a great candidate to be proposed as a spec to stx-specs. That way you can send out the link to the Gerrit review which works better with the mail archive as well as it is accessible from there too. Gerrit also helps with reviews but doesn’t force you to keep all the discussions there you can always reference the review link in mail threads. What do you think about moving the document there? Thanks, Ildikó > On 2018. Sep 17., at 9:17, Xu, Chenjie <chenjie.xu@intel.com> wrote: > > > > Hi Matt, > We analyze the patch 4ae5a58 related to l2pop. An RFE has been written(You can find it in the attachment). Could you please help to review and comment? Thanks very much! > > > Best Regards, > Xu, Chenjie > > > <RFE_EXTEND_L2POP_FDB_INFORMATION.docx>_______________________________________________ > Starlingx-discuss mailing list > Starlingx-discuss@lists.starlingx.io > http://lists.starlingx.io/cgi-bin/mailman/listinfo/starlingx-discuss
Hi Matt, I missed the Neutron bit, thanks for clarifying that. Totally agree to upload it to neutron-specs. Thanks, Ildikó
On 2018. Sep 18., at 17:14, Peters, Matt <Matt.Peters@windriver.com> wrote:
Hi Ildikó, This RFE is specific to neutron, therefore I think it makes sense to publish this to the neutron-specs for review rather than the stx-specs. I do agree that the mailing list is not the best way to exchange review comments and makes sense to ensure the docs are pushed to an appropriate spec repo as soon as possible.
Regards, Matt
On 2018-09-18, 3:46 AM, "Ildiko Vancsa" <ildiko.vancsa@gmail.com> wrote:
Hi,
I think the attached document would be a great candidate to be proposed as a spec to stx-specs. That way you can send out the link to the Gerrit review which works better with the mail archive as well as it is accessible from there too.
Gerrit also helps with reviews but doesn’t force you to keep all the discussions there you can always reference the review link in mail threads.
What do you think about moving the document there?
Thanks, Ildikó
On 2018. Sep 17., at 9:17, Xu, Chenjie <chenjie.xu@intel.com> wrote:
Hi Matt, We analyze the patch 4ae5a58 related to l2pop. An RFE has been written(You can find it in the attachment). Could you please help to review and comment? Thanks very much!
Best Regards, Xu, Chenjie
<RFE_EXTEND_L2POP_FDB_INFORMATION.docx>_______________________________________________ Starlingx-discuss mailing list Starlingx-discuss@lists.starlingx.io http://lists.starlingx.io/cgi-bin/mailman/listinfo/starlingx-discuss
Hi Chenjie, I think the RFE looks good. I have no specific comments about the content, however, I think the references should be checked since there are duplicates. Everything else looks great. Regards, Matt From: "Xu, Chenjie" <chenjie.xu@intel.com> Date: Monday, September 17, 2018 at 3:18 AM To: "Peters, Matt" <Matt.Peters@windriver.com> Cc: "starlingx-discuss@lists.starlingx.io" <starlingx-discuss@lists.starlingx.io> Subject: [Starlingx-discuss] Analysis of patch 4ae5a58 for StartlingX upstreaming Hi Matt, We analyze the patch 4ae5a58 related to l2pop. An RFE has been written(You can find it in the attachment). Could you please help to review and comment? Thanks very much! Best Regards, Xu, Chenjie
Hi Matt, Thanks for your comment! The duplicate in the reference has been removed and the RFE has been checked again. Could you please help to review and comment? Thanks very much! Best Regards, Xu, Chenjie From: Peters, Matt [mailto:Matt.Peters@windriver.com] Sent: Tuesday, September 18, 2018 10:56 PM To: Xu, Chenjie <chenjie.xu@intel.com> Cc: starlingx-discuss@lists.starlingx.io Subject: Re: [Starlingx-discuss] Analysis of patch 4ae5a58 for StartlingX upstreaming Hi Chenjie, I think the RFE looks good. I have no specific comments about the content, however, I think the references should be checked since there are duplicates. Everything else looks great. Regards, Matt From: "Xu, Chenjie" <chenjie.xu@intel.com<mailto:chenjie.xu@intel.com>> Date: Monday, September 17, 2018 at 3:18 AM To: "Peters, Matt" <Matt.Peters@windriver.com<mailto:Matt.Peters@windriver.com>> Cc: "starlingx-discuss@lists.starlingx.io<mailto:starlingx-discuss@lists.starlingx.io>" <starlingx-discuss@lists.starlingx.io<mailto:starlingx-discuss@lists.starlingx.io>> Subject: [Starlingx-discuss] Analysis of patch 4ae5a58 for StartlingX upstreaming Hi Matt, We analyze the patch 4ae5a58 related to l2pop. An RFE has been written(You can find it in the attachment). Could you please help to review and comment? Thanks very much! Best Regards, Xu, Chenjie
Hi Chenjie, Looks good. Regards, Matt From: "Xu, Chenjie" <chenjie.xu@intel.com> Date: Tuesday, September 18, 2018 at 10:24 PM To: "Peters, Matt" <Matt.Peters@windriver.com> Cc: "starlingx-discuss@lists.starlingx.io" <starlingx-discuss@lists.starlingx.io> Subject: RE: [Starlingx-discuss] Analysis of patch 4ae5a58 for StartlingX upstreaming Hi Matt, Thanks for your comment! The duplicate in the reference has been removed and the RFE has been checked again. Could you please help to review and comment? Thanks very much! Best Regards, Xu, Chenjie From: Peters, Matt [mailto:Matt.Peters@windriver.com] Sent: Tuesday, September 18, 2018 10:56 PM To: Xu, Chenjie <chenjie.xu@intel.com> Cc: starlingx-discuss@lists.starlingx.io Subject: Re: [Starlingx-discuss] Analysis of patch 4ae5a58 for StartlingX upstreaming Hi Chenjie, I think the RFE looks good. I have no specific comments about the content, however, I think the references should be checked since there are duplicates. Everything else looks great. Regards, Matt From: "Xu, Chenjie" <chenjie.xu@intel.com<mailto:chenjie.xu@intel.com>> Date: Monday, September 17, 2018 at 3:18 AM To: "Peters, Matt" <Matt.Peters@windriver.com<mailto:Matt.Peters@windriver.com>> Cc: "starlingx-discuss@lists.starlingx.io<mailto:starlingx-discuss@lists.starlingx.io>" <starlingx-discuss@lists.starlingx.io<mailto:starlingx-discuss@lists.starlingx.io>> Subject: [Starlingx-discuss] Analysis of patch 4ae5a58 for StartlingX upstreaming Hi Matt, We analyze the patch 4ae5a58 related to l2pop. An RFE has been written(You can find it in the attachment). Could you please help to review and comment? Thanks very much! Best Regards, Xu, Chenjie
Hi Matt, Thank you for your comment! Best Regard, Xu, Chenjie From: Peters, Matt [mailto:Matt.Peters@windriver.com] Sent: Wednesday, September 19, 2018 8:09 PM To: Xu, Chenjie <chenjie.xu@intel.com> Cc: starlingx-discuss@lists.starlingx.io Subject: Re: [Starlingx-discuss] Analysis of patch 4ae5a58 for StartlingX upstreaming Hi Chenjie, Looks good. Regards, Matt From: "Xu, Chenjie" <chenjie.xu@intel.com<mailto:chenjie.xu@intel.com>> Date: Tuesday, September 18, 2018 at 10:24 PM To: "Peters, Matt" <Matt.Peters@windriver.com<mailto:Matt.Peters@windriver.com>> Cc: "starlingx-discuss@lists.starlingx.io<mailto:starlingx-discuss@lists.starlingx.io>" <starlingx-discuss@lists.starlingx.io<mailto:starlingx-discuss@lists.starlingx.io>> Subject: RE: [Starlingx-discuss] Analysis of patch 4ae5a58 for StartlingX upstreaming Hi Matt, Thanks for your comment! The duplicate in the reference has been removed and the RFE has been checked again. Could you please help to review and comment? Thanks very much! Best Regards, Xu, Chenjie From: Peters, Matt [mailto:Matt.Peters@windriver.com] Sent: Tuesday, September 18, 2018 10:56 PM To: Xu, Chenjie <chenjie.xu@intel.com<mailto:chenjie.xu@intel.com>> Cc: starlingx-discuss@lists.starlingx.io<mailto:starlingx-discuss@lists.starlingx.io> Subject: Re: [Starlingx-discuss] Analysis of patch 4ae5a58 for StartlingX upstreaming Hi Chenjie, I think the RFE looks good. I have no specific comments about the content, however, I think the references should be checked since there are duplicates. Everything else looks great. Regards, Matt From: "Xu, Chenjie" <chenjie.xu@intel.com<mailto:chenjie.xu@intel.com>> Date: Monday, September 17, 2018 at 3:18 AM To: "Peters, Matt" <Matt.Peters@windriver.com<mailto:Matt.Peters@windriver.com>> Cc: "starlingx-discuss@lists.starlingx.io<mailto:starlingx-discuss@lists.starlingx.io>" <starlingx-discuss@lists.starlingx.io<mailto:starlingx-discuss@lists.starlingx.io>> Subject: [Starlingx-discuss] Analysis of patch 4ae5a58 for StartlingX upstreaming Hi Matt, We analyze the patch 4ae5a58 related to l2pop. An RFE has been written(You can find it in the attachment). Could you please help to review and comment? Thanks very much! Best Regards, Xu, Chenjie
participants (3)
-
Ildiko Vancsa
-
Peters, Matt
-
Xu, Chenjie