[Starlingx-discuss] Effort to make zuul linters happy

Penney, Don Don.Penney at windriver.com
Fri Aug 10 03:00:24 UTC 2018


1. The xargs commands in the tox.ini files should be updated to include --no-run-if-empty
2. While the io-monitor path is no longer valid, it looks like it's an exclusion argument to the find commands, to skip any yaml files found under that directory. It doesn't cause the find command to fail. It should be removed from the tox.ini files, I agree, but it seems to have no effect.

-----Original Message-----
From: Chen, Yan [mailto:yan.chen at intel.com] 
Sent: Thursday, August 09, 2018 10:27 PM
To: Plant, Lachlan; Rowsell, Brent; Cordoba Malibran, Erich; starlingx-discuss at lists.starlingx.io
Subject: Re: [Starlingx-discuss] Effort to make zuul linters happy

Hi,
I just checked the zuul script under stx-fault, and here's what I found:

The linters job will do 2 checks:
1. check *.sh files under this project with bashate.
  But we don't have shell file in this project, so the find cmd will return nothing and the bashate will fail.
2. check *.yaml files with yamllint.
  But in the cmd, it will find yaml files with "-name middleware/io-monitor/recipes-common/io-monitor/io-monitor/io_monitor/test-tools/yaml/*" which is not a right folder under this project. So it will always fail.

As most of the linters jobs in different projects are the same (copied as default), I guess we can fix them with one synced script.

Yan

-----Original Message-----
From: Plant, Lachlan [mailto:Lachlan.Plant at windriver.com] 
Sent: Friday, August 10, 2018 02:09
To: Rowsell, Brent <Brent.Rowsell at windriver.com>; Cordoba Malibran, Erich <erich.cordoba.malibran at intel.com>; starlingx-discuss at lists.starlingx.io
Subject: Re: [Starlingx-discuss] Effort to make zuul linters happy

I am interested in helping out with this effort. I have free cycles starting on Monday, please keep me in the loop.
Lachlan 

-----Original Message-----
From: Rowsell, Brent [mailto:Brent.Rowsell at windriver.com] 
Sent: August-08-18 3:03 PM
To: Cordoba Malibran, Erich; starlingx-discuss at lists.starlingx.io
Subject: Re: [Starlingx-discuss] Effort to make zuul linters happy

These repos are being deleted. 

https://storyboard.openstack.org/#!/story/2003361 : stx-gplv2
https://storyboard.openstack.org/#!/story/2003363 : stx-gplv3
https://storyboard.openstack.org/#!/story/2003373 : stx-utils

Brent 

-----Original Message-----
From: Cordoba Malibran, Erich [mailto:erich.cordoba.malibran at intel.com] 
Sent: Wednesday, August 8, 2018 2:57 PM
To: starlingx-discuss at lists.starlingx.io
Subject: [Starlingx-discuss] Effort to make zuul linters happy

Hi all, 

Currently the zuul check only verifies linters and some of them fails.
The zuul gate stage is disabled to make the integration possible. As it is desirable to use Zuul for gating code merges we need first to solve the linter problems in every repository.

I've created a set of stories for each repository to start this effort.
Now the only tasks created there is to go into Zuul logs and review what needs to be done to solve the issues and create the related tasks.

In case someone wants to join this effort, here is the list of stories.

https://storyboard.openstack.org/#!/story/2003359 : stx-clients
https://storyboard.openstack.org/#!/story/2003360 : stx-config
https://storyboard.openstack.org/#!/story/2003361 : stx-fault
https://storyboard.openstack.org/#!/story/2003361 : stx-gplv2
https://storyboard.openstack.org/#!/story/2003363 : stx-gplv3
https://storyboard.openstack.org/#!/story/2003364 : stx-gui
https://storyboard.openstack.org/#!/story/2003365 : stx-ha
https://storyboard.openstack.org/#!/story/2003366 : stx-integ
https://storyboard.openstack.org/#!/story/2003367 : stx-manifest
https://storyboard.openstack.org/#!/story/2003368 : stx-metal
https://storyboard.openstack.org/#!/story/2003369 : stx-nfv
https://storyboard.openstack.org/#!/story/2003370 : stx-root
https://storyboard.openstack.org/#!/story/2003371 : stx-update
https://storyboard.openstack.org/#!/story/2003372 : stx-upstream
https://storyboard.openstack.org/#!/story/2003373 : stx-utils

Thanks

-Erich
_______________________________________________
Starlingx-discuss mailing list
Starlingx-discuss at lists.starlingx.io
http://lists.starlingx.io/cgi-bin/mailman/listinfo/starlingx-discuss
_______________________________________________
Starlingx-discuss mailing list
Starlingx-discuss at lists.starlingx.io
http://lists.starlingx.io/cgi-bin/mailman/listinfo/starlingx-discuss
_______________________________________________
Starlingx-discuss mailing list
Starlingx-discuss at lists.starlingx.io
http://lists.starlingx.io/cgi-bin/mailman/listinfo/starlingx-discuss
_______________________________________________
Starlingx-discuss mailing list
Starlingx-discuss at lists.starlingx.io
http://lists.starlingx.io/cgi-bin/mailman/listinfo/starlingx-discuss


More information about the Starlingx-discuss mailing list