[Starlingx-discuss] What is the function of patches directory in StarlingX source code

[Liu, Changcheng]

Hi Bin,
     Thanks for creating the story to track it.
     Sorry, I don't have time to take this task. Currently, I'm busy at changing other components to adapt to new ceph(v13.2.2).

B.R.
Changcheng

From: Qian, Bin [mailto:Bin.Qian at windriver.com]
Sent: Friday, January 11, 2019 10:12 AM
To: Liu, Changcheng <changcheng.liu at intel.com>; Bailey, Henry Albert (Al) <Al.Bailey at windriver.com>
Cc: starlingx-discuss at lists.starlingx.io
Subject: RE: [Starlingx-discuss] What is the function of patches directory in StarlingX source code

Hi, Changcheng

I've created the user story https://storyboard.openstack.org/#!/story/20047<https://storyboard.openstack.org/#!/story/2004752,>.
I am wondering if you can take this task?

Thanks,

Bin

________________________________
From: Liu, Changcheng [changcheng.liu at intel.com]
Sent: Wednesday, January 09, 2019 5:31 PM
To: Qian, Bin; Bailey, Henry Albert (Al)
Cc: starlingx-discuss at lists.starlingx.io<mailto:starlingx-discuss at lists.starlingx.io>
Subject: RE: [Starlingx-discuss] What is the function of patches directory in StarlingX source code
Thanks Bin.

From: Qian, Bin [mailto:Bin.Qian at windriver.com]
Sent: Thursday, January 10, 2019 12:28 AM
To: Liu, Changcheng <changcheng.liu at intel.com<mailto:changcheng.liu at intel.com>>; Bailey, Henry Albert (Al) <Al.Bailey at windriver.com<mailto:Al.Bailey at windriver.com>>
Cc: starlingx-discuss at lists.starlingx.io<mailto:starlingx-discuss at lists.starlingx.io>
Subject: RE: [Starlingx-discuss] What is the function of patches directory in StarlingX source code

The code is no longer used. I will setup a task to do some cleanup.

Bin
________________________________
From: Liu, Changcheng [changcheng.liu at intel.com]
Sent: Tuesday, January 08, 2019 7:57 AM
To: Bailey, Henry Albert (Al); Qian, Bin
Cc: starlingx-discuss at lists.starlingx.io<mailto:starlingx-discuss at lists.starlingx.io>
Subject: RE: [Starlingx-discuss] What is the function of patches directory in StarlingX source code
Hi AI & Bin,
      Please help submit patch to remove them from source code if we could make sure they're not needed anymore.

B.R.
Changcheng
From: Bailey, Henry Albert (Al) [mailto:Al.Bailey at windriver.com]
Sent: Tuesday, January 8, 2019 10:08 PM
To: Liu, Changcheng <changcheng.liu at intel.com<mailto:changcheng.liu at intel.com>>; Qian, Bin <Bin.Qian at windriver.com<mailto:Bin.Qian at windriver.com>>
Cc: starlingx-discuss at lists.starlingx.io<mailto:starlingx-discuss at lists.starlingx.io>
Subject: RE: [Starlingx-discuss] What is the function of patches directory in StarlingX source code

I don't think any of those files in that patches folder are needed anymore.  They were added to the c ode back to 2015.
Bin will know for sure, whether or not they can be removed.

Al

From: Liu, Changcheng [mailto:changcheng.liu at intel.com]
Sent: Monday, January 07, 2019 8:26 PM
To: Bailey, Henry Albert (Al); Qian, Bin
Cc: starlingx-discuss at lists.starlingx.io<mailto:starlingx-discuss at lists.starlingx.io>
Subject: RE: [Starlingx-discuss] What is the function of patches directory in StarlingX source code

Hi AI & Bin,
     Does sm_patch.py make effect when installing the ISO image or it makes effect to apply all the patches when building the source code?
     Specifically, what's below patch used for? Could I remove it from source code directly?
            cgcs-root/stx/stx-ha/service-mgmt/sm-db-1.0.0/patches/sm_db_ceph_install.patch
     I'm removing ceph-rest-api from source code and replace it with other service. The above patch define some service realted with ceph-rest-api. I don't know whether I need change that patch file.

B.R.
Changcheng

From: Bailey, Henry Albert (Al) [mailto:Al.Bailey at windriver.com]
Sent: Monday, January 7, 2019 9:50 PM
To: Liu, Changcheng <changcheng.liu at intel.com<mailto:changcheng.liu at intel.com>>; starlingx-discuss at lists.starlingx.io<mailto:starlingx-discuss at lists.starlingx.io>
Cc: Qian, Bin <Bin.Qian at windriver.com<mailto:Bin.Qian at windriver.com>>
Subject: RE: [Starlingx-discuss] What is the function of patches directory in StarlingX source code

I believe the contents of that folder are installed into a patches folder, and acted upon by the sm-patch utility
https://github.com/openstack/stx-ha/blob/master/service-mgmt-tools/sm-tools/sm_tools/sm_patch.py

It looks like they populate "V1"  tables.   Bin should be able to indicate if we still make use of the V1 tables or not.

Al


From: Liu, Changcheng [mailto:changcheng.liu at intel.com]
Sent: Sunday, January 06, 2019 10:57 PM
To: starlingx-discuss at lists.starlingx.io<mailto:starlingx-discuss at lists.starlingx.io>
Subject: [Starlingx-discuss] What is the function of patches directory in StarlingX source code

Hi all,
     What's the function of patches directory in StartlingX source code?
     For example: cgcs-root/stx/stx-ha/service-mgmt/sm-db-1.0.0/patches/sm_db_ceph_install.patch

Regards,
Changcheng

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.starlingx.io/pipermail/starlingx-discuss/attachments/20190111/9c5e6159/attachment.html>