[Starlingx-discuss] Malformed Depends-On tag can cause unexpected merge

[Penney, Don]

Hi all,

Please be careful when adding dependencies to your commit messages to ensure the formatting is correct. If it is not, then Gerrit/Zuul may not properly handle the dependency and allow a commit to merge before the dependency is merged. It appears that a space is mandatory after the "Depends-On:" tag.

Proper formatting:
Depends-On: https://review.opendev.org/XXXXXX

Improper:
Depends-On:https://review.opendev.org/XXXXXX

We saw updates merge this morning prematurely, apparently due to a commit message that was missing this space after the Depends-On tag.

As a side note, I believe the syntax of "Depends-On: CHANGE-ID" is deprecated, maybe due to the potential for CHANGE-ID matching multiple reviews. The suggested syntax is to use the Gerrit review URL.

Cheers,
Don.


Don Penney, Developer, Wind River


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.starlingx.io/pipermail/starlingx-discuss/attachments/20191112/fb462087/attachment.html>