[Starlingx-discuss] Malformed Depends-On tag can cause unexpected merge

Jeremy Stanley fungi at yuggoth.org
Tue Nov 12 18:27:31 UTC 2019


On 2019-11-12 18:14:48 +0000 (+0000), Penney, Don wrote:
[...]
> As a side note, I believe the syntax of "Depends-On: CHANGE-ID" is
> deprecated, maybe due to the potential for CHANGE-ID matching
> multiple reviews. The suggested syntax is to use the Gerrit review
> URL.

The reason using the Change-Id for Depends-On is deprecated is that
Zuul v3 added the ability to have multiple connections to different
code review systems, so a raw Change-Id is insufficient for locating
the review if it's accessed through a different connection. GitHub
doesn't even have anything analogous to Gerrit's Change-Id, so Zuul
needed to adopt a more generic solution to support it anyway.
-- 
Jeremy Stanley
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: not available
URL: <http://lists.starlingx.io/pipermail/starlingx-discuss/attachments/20191112/250755b0/attachment.sig>


More information about the Starlingx-discuss mailing list