[Starlingx-discuss] Full process to update/add documentation pages (gerrit review push issue)

[VanCutsem, Geoffroy]

On Thu, 2019-09-12 at 23:14 +0000, Jeremy Stanley wrote:
> On 2019-09-12 16:15:16 +0200 (+0200), Dominig ar Foll (Intel Open
> Source) wrote:
> [...]
> > git review -t "initial creation Doc page Navigate Git Code
> > story/2005184"
> [...]
> > error: src refspec creation does not match any.
> > error: src refspec Doc does not match any.
> > error: src refspec page does not match any.
> > error: src refspec Navigate does not match any.
> > error: src refspec Git does not match any.
> > error: src refspec Code does not match any.
> > error: src refspec story/2005184 does not match any.
> [...]
> 
> I know it's been worked around and discussed in other replies
> already, but just to follow up I'm trying to work out whether spaces
> in change topics should be supported. I'd never tried it before, and
> indeed all the documentation (including Gerrit's own) has no
> examples of setting a topic with a space in it via git push (what
> git review is using behind the scenes there). Gerrit *does* let you
> set change topics with spaces in them through its WebUI, but I can't
> figure out any viable quoting or encoding solution to create them on
> push. At best, we should probably trap for such attempts in the
> git-review option parser and return a sensible error message, so
> thanks for bringing this to light. I'll get some solution for this
> into the next release so it hopefully doesn't bite anyone else.

I suspect this is a problem at the git-review Python code, not a
problem with Gerrit itself. I took a (very) quick look at the code and
noticed it uses the 'argparse' module to parse all arguments. This is
the issue I believe we're hitting: https://bugs.python.org/issue22433
... unfortunately it's been sitting there, opened for 5 years now.

Note: enclosing the string in quotes should help but I've seen reports
that it would only work when using '--topic='.

@Dominig, if you can spare a couple of minutes, I'd be curious to know
if the following command works for you:
 git review --topic="initial creation Doc page Navigate Git Code
story/2005184"

Geoffroy