[Starlingx-discuss] Help required on the code commit for the horizon repo

Kumar, Sharath sharath.kumar at intel.com
Wed Dec 9 07:15:02 UTC 2020 

Hi Tyler,

I think the best way to go about it would be to leave horizon/openstack_dashboard packages untouched, but as part of the image build bring in the fault management plugin as its own package

We also considered above method, but we are stuck on the point that goes back to mario's patch (https://review.opendev.org/c/starlingx/upstream/+/661423/4/openstack/python-horizon/centos/stx-horizon.stable_docker_image#6) of customization which was considered as hack and abandoned.

copy the enabled files from it into the openstack_dashboard enabled directory inside of the image.

Considering we make FM plugin and include the changes as pip packages, please let us know how to enable this ?

Please provide your input at the earliest, let me know if you can have separate discussion.

Regards,
Sharath
From: Smith, Tyler <tyler.smith at windriver.com>
Sent: Wednesday, December 9, 2020 12:26 AM
To: Kumar, Sharath <sharath.kumar at intel.com>; Wang, Jing (Angie) <Angie.Wang at windriver.com>; Wensley, Barton <Barton.Wensley at windriver.com>; Bujold, Kristine <Kristine.Bujold at windriver.com>; starlingx-discuss at lists.starlingx.io
Cc: Mukherjee, Sanjay K <sanjay.k.mukherjee at intel.com>; Kalvala, Haridhar <haridhar.kalvala at intel.com>; Bhat, Gopalkrishna <gopalkrishna.bhat at intel.com>
Subject: RE: Help required on the code commit for the horizon repo

I think the best way to go about it would be to leave horizon/openstack_dashboard packages untouched, but as part of the image build bring in the fault_management plugin as its own package and copy the enabled files from it into the openstack_dashboard enabled directory inside of the image.

The discussion from a while ago was whether starlingx_dashboard plugin could contain everything and have only the relevant dashboards enabled where needed in containerized and platform horizon.  It looks like that ran into some issues, so the other approach would be to separate the fault_management components into its own plugin/package, which is what would be imported into the docker image.

Tyler


From: Kumar, Sharath <sharath.kumar at intel.com<mailto:sharath.kumar at intel.com>>
Sent: December 8, 2020 12:46 PM
To: Smith, Tyler <tyler.smith at windriver.com<mailto:tyler.smith at windriver.com>>; Wang, Jing (Angie) <Angie.Wang at windriver.com<mailto:Angie.Wang at windriver.com>>; Wensley, Barton <Barton.Wensley at windriver.com<mailto:Barton.Wensley at windriver.com>>; Bujold, Kristine <Kristine.Bujold at windriver.com<mailto:Kristine.Bujold at windriver.com>>; starlingx-discuss at lists.starlingx.io<mailto:starlingx-discuss at lists.starlingx.io>
Cc: Mukherjee, Sanjay K <sanjay.k.mukherjee at intel.com<mailto:sanjay.k.mukherjee at intel.com>>; Kalvala, Haridhar <haridhar.kalvala at intel.com<mailto:haridhar.kalvala at intel.com>>; Bhat, Gopalkrishna <gopalkrishna.bhat at intel.com<mailto:gopalkrishna.bhat at intel.com>>
Subject: RE: Help required on the code commit for the horizon repo

[Please note this e-mail is from an EXTERNAL e-mail address]
Hi Tyler,

Thank you for the response.

I believe, once code is push to stx/gui repo it will be part of starlingx dashboard, then how openstack horizon docker image(stx-horizon) will be built using custom code which will be present in stx/gui instead of upstream horizon repo?

As per my understanding, drawing below diagram of horizon docker image build process. Please let me know your views.
[cid:image001.png at 01D6CE28.84D566C0]

Regards,
Sharath
From: Smith, Tyler <tyler.smith at windriver.com<mailto:tyler.smith at windriver.com>>
Sent: Tuesday, December 8, 2020 9:09 PM
To: Kumar, Sharath <sharath.kumar at intel.com<mailto:sharath.kumar at intel.com>>; Wang, Jing (Angie) <Angie.Wang at windriver.com<mailto:Angie.Wang at windriver.com>>; Wensley, Barton <Barton.Wensley at windriver.com<mailto:Barton.Wensley at windriver.com>>; Bujold, Kristine <Kristine.Bujold at windriver.com<mailto:Kristine.Bujold at windriver.com>>; starlingx-discuss at lists.starlingx.io<mailto:starlingx-discuss at lists.starlingx.io>
Cc: Mukherjee, Sanjay K <sanjay.k.mukherjee at intel.com<mailto:sanjay.k.mukherjee at intel.com>>; Kalvala, Haridhar <haridhar.kalvala at intel.com<mailto:haridhar.kalvala at intel.com>>; Bhat, Gopalkrishna <gopalkrishna.bhat at intel.com<mailto:gopalkrishna.bhat at intel.com>>
Subject: RE: Help required on the code commit for the horizon repo

Hi Sharath,

The code will have to live in the stx-gui repo at /stx/gui/ as this isn't a change we would want to push to upstream horizon.  Bart, Kristine, Angie, and myself will be able to review your code.

Thanks,
Tyler

From: Kumar, Sharath <sharath.kumar at intel.com<mailto:sharath.kumar at intel.com>>
Sent: December 8, 2020 9:46 AM
To: Wang, Jing (Angie) <Angie.Wang at windriver.com<mailto:Angie.Wang at windriver.com>>; Wensley, Barton <Barton.Wensley at windriver.com<mailto:Barton.Wensley at windriver.com>>; Bujold, Kristine <Kristine.Bujold at windriver.com<mailto:Kristine.Bujold at windriver.com>>; Smith, Tyler <tyler.smith at windriver.com<mailto:tyler.smith at windriver.com>>; starlingx-discuss at lists.starlingx.io<mailto:starlingx-discuss at lists.starlingx.io>
Cc: Mukherjee, Sanjay K <sanjay.k.mukherjee at intel.com<mailto:sanjay.k.mukherjee at intel.com>>; Kalvala, Haridhar <haridhar.kalvala at intel.com<mailto:haridhar.kalvala at intel.com>>; Bhat, Gopalkrishna <gopalkrishna.bhat at intel.com<mailto:gopalkrishna.bhat at intel.com>>
Subject: RE: Help required on the code commit for the horizon repo

[Please note this e-mail is from an EXTERNAL e-mail address]
Adding starlingx-discussion.

From: Kumar, Sharath
Sent: Tuesday, December 8, 2020 7:54 PM
To: 'angie.wang at windriver.com' <angie.wang at windriver.com<mailto:angie.wang at windriver.com>>; Wensley, Barton <Barton.Wensley at windriver.com<mailto:Barton.Wensley at windriver.com>>; 'Kristine.Bujold at windriver.com' <Kristine.Bujold at windriver.com<mailto:Kristine.Bujold at windriver.com>>; Smith, Tyler <tyler.smith at windriver.com<mailto:tyler.smith at windriver.com>>
Subject: Help required on the code commit for the horizon repo

Hi All,

I am working on Fault management front end coding for openstack dashboard, and to push my changes for the review, I have some questions on branch and commits.

My code is currently part of horizon repo which comes under distro layer. In the build layer, code will be present under below path:
       /stx/distro/cgcs-root/stx/git/horizon/openstack_dashboard/dashboards.

Under horizon repo, only openstack community branches are present :
       remotes/m/master -> openstack/stable/train
       remotes/openstack/master
       remotes/openstack/stable/ocata
       remotes/openstack/stable/pike
       remotes/openstack/stable/queens
       remotes/openstack/stable/rocky
       remotes/openstack/stable/stein
       remotes/openstack/stable/train
       remotes/openstack/stable/ussuri
       remotes/openstack/stable/Victoria

I can see starlingx branches under below path in distro layer:
/stx/distro/cgcs-root/stx/git

Branches:
  remotes/m/master -> starlingx/master
  remotes/starlingx/centos75
  remotes/starlingx/f/centos75
  remotes/starlingx/f/centos76
  remotes/starlingx/f/centos8
  remotes/starlingx/f/keystone-db
  remotes/starlingx/m/2018.07
  remotes/starlingx/m/2018.08
  remotes/starlingx/master
remotes/starlingx/r/2018.10
  remotes/starlingx/r/stx.2.0
  remotes/starlingx/r/stx.3.0
  remotes/starlingx/r/stx.4.0

Now challenge is, to push my code under horizon repo only openstack branches are listing , not starlingx.

My questions:

  1.  With the present repo path and branches,  I cannot push code because it will go to the openstack community. Could you please suggest how can I push my changes to the starlingx community for review?
  2.  Whom should I add from WindRiver team to review my code which are part of horizon repo?

Thank you for helping me here.

Regards,
Sharath
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.starlingx.io/pipermail/starlingx-discuss/attachments/20201209/fcc55ce7/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image001.png
Type: image/png
Size: 22306 bytes
Desc: image001.png
URL: <http://lists.starlingx.io/pipermail/starlingx-discuss/attachments/20201209/fcc55ce7/attachment-0001.png>

More information about the Starlingx-discuss mailing list